Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against null process states #658

Merged

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jan 4, 2025

Closes #657

@edan-bainglass edan-bainglass self-assigned this Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (59d6c4f) to head (e5a8d61).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiidalab_widgets_base/nodes.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   83.48%   83.46%   -0.02%     
==========================================
  Files          17       17              
  Lines        3566     3568       +2     
==========================================
+ Hits         2977     2978       +1     
- Misses        589      590       +1     
Flag Coverage Δ
python-3.11 83.46% <50.00%> (-0.02%) ⬇️
python-3.9 83.50% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass merged commit 7a93035 into aiidalab:master Jan 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process_state is not always there when we probe it
3 participants